[Piglit] [PATCH] arb_enhanced_layouts: fix shader GLSL version requirement

Timothy Arceri timothy.arceri at collabora.com
Wed Oct 26 22:56:03 UTC 2016


Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>

On Thu, 2016-07-28 at 11:37 +0200, Iago Toral Quiroga wrote:
> The test declares that only GLSL 1.40 is required, but then shaders
> use version 4.20, leading to execution failures if the platform does
> not support 4.20. Just require GLSL 1.40 in the shaders too, since
> that is sufficient and consistent with other similar tests.
> ---
>  .../execution/component-layout/vs-fs-
> doubles.shader_test              | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/spec/arb_enhanced_layouts/execution/component-
> layout/vs-fs-doubles.shader_test
> b/tests/spec/arb_enhanced_layouts/execution/component-layout/vs-fs-
> doubles.shader_test
> index de33459..2507668 100644
> --- a/tests/spec/arb_enhanced_layouts/execution/component-layout/vs-
> fs-doubles.shader_test
> +++ b/tests/spec/arb_enhanced_layouts/execution/component-layout/vs-
> fs-doubles.shader_test
> @@ -7,7 +7,7 @@ GL_ARB_separate_shader_objects
>  GL_ARB_gpu_shader_fp64
>  
>  [vertex shader]
> -#version 420
> +#version 140
>  #extension GL_ARB_enhanced_layouts: require
>  #extension GL_ARB_separate_shader_objects: require
>  #extension GL_ARB_gpu_shader_fp64: require
> @@ -30,7 +30,7 @@ void main()
>  }
>  
>  [fragment shader]
> -#version 420
> +#version 140
>  #extension GL_ARB_enhanced_layouts: require
>  #extension GL_ARB_separate_shader_objects: require
>  #extension GL_ARB_gpu_shader_fp64: require


More information about the Piglit mailing list