[Piglit] [PATCH v2] tests: fix ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag

[Ian Romanick]

On 08/31/2016 03:23 PM, Dylan Baker wrote:
> This test has two problems.
> 1) It uses the OpenGL ARB extension instead of the OES extension
> 2) It doesn't include that extension in the require block.
> 3) It doesn't specify any precision

Arg.  I think this was the result of a bad sed-job without any humans at
the wheel.

> 
> v2: - replace GL_ARB_texture_storage with the OES equivalent (Ilia)
>     - Add precision specifiers
> 
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> cc: Ian Romanick <ian.d.romanick at intel.com>

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

Though I would like to see the follow-up that splits this into two tests.

> cc: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  .../glsl-es-3.10/compiler/all-functions.frag          | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag b/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag
> index c538aaf..380b979 100644
> --- a/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag
> +++ b/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.frag
> @@ -1,21 +1,22 @@
>  // [config]
>  // expect_result: pass
>  // glsl_version: 3.10
> -// require_extensions: GL_EXT_shader_samples_identical
> +// require_extensions: GL_EXT_shader_samples_identical GL_OES_texture_storage_multisample_2d_array
>  // [end config]
>  
>  #version 310 es
> -#extension GL_ARB_texture_multisample: require
> +#extension GL_OES_texture_storage_multisample_2d_array: require
>  #extension GL_EXT_shader_samples_identical: require
>  
> -uniform sampler2DMS s1;
> -uniform isampler2DMS s2;
> -uniform usampler2DMS s3;
> -uniform sampler2DMSArray s4;
> -uniform isampler2DMSArray s5;
> -uniform usampler2DMSArray s6;
>  
> -out vec2 data;
> +uniform mediump sampler2DMS s1;
> +uniform mediump isampler2DMS s2;
> +uniform mediump usampler2DMS s3;
> +uniform mediump sampler2DMSArray s4;
> +uniform mediump isampler2DMSArray s5;
> +uniform mediump usampler2DMSArray s6;
> +
> +out mediump vec2 data;
>  
>  void main()
>  {
>