[Piglit] [PATCH] tests: fix ext_shader_samples_identical ES 3.1 vert test

Alejandro Piñeiro apinheiro at igalia.com
Fri Sep 2 08:04:32 UTC 2016


Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>

On 02/09/16 02:36, Dylan Baker wrote:
> This test is currently completely broken. It uses names defined in
> GL_OES_texture_storage_multisample_2d_array without adding a #extension
> directive or a config requirement. It also doesn't declare precision.
> 
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> cc: idr at freedesktop.org
> ---
>  .../glsl-es-3.10/compiler/all-functions.vert              | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.vert b/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.vert
> index cc188ab..e1b154d 100644
> --- a/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.vert
> +++ b/tests/spec/ext_shader_samples_identical/glsl-es-3.10/compiler/all-functions.vert
> @@ -1,18 +1,19 @@
>  // [config]
>  // expect_result: pass
>  // glsl_version: 3.10
> -// require_extensions: GL_EXT_shader_samples_identical
> +// require_extensions: GL_EXT_shader_samples_identical GL_OES_texture_storage_multisample_2d_array
>  // [end config]
>  
>  #version 310 es
>  #extension GL_EXT_shader_samples_identical: require
> +#extension GL_OES_texture_storage_multisample_2d_array: require
>  
> -uniform sampler2DMS s1;
> -uniform isampler2DMS s2;
> -uniform usampler2DMS s3;
> -uniform sampler2DMSArray s4;
> -uniform isampler2DMSArray s5;
> -uniform usampler2DMSArray s6;
> +uniform mediump sampler2DMS s1;
> +uniform mediump isampler2DMS s2;
> +uniform mediump usampler2DMS s3;
> +uniform mediump sampler2DMSArray s4;
> +uniform mediump isampler2DMSArray s5;
> +uniform mediump usampler2DMSArray s6;
>  
>  flat out ivec2 data;
>  
> 

-- 
Alejandro Piñeiro <apinheiro at igalia.com>


More information about the Piglit mailing list