[Piglit] [PATCH] egl-nok-swap-region: Fix build against new eglext.h

Emil Velikov emil.l.velikov at gmail.com
Thu Sep 8 02:42:56 UTC 2016


On 7 September 2016 at 21:50, Adam Jackson <ajax at redhat.com> wrote:
> New eglext.h has the typedef corrected to end in PROC like everything
> else. Rename the old string to the new when building against old
> headers.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  tests/egl/egl-nok-swap-region.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/egl/egl-nok-swap-region.c b/tests/egl/egl-nok-swap-region.c
> index 075df97..6512b6b 100644
> --- a/tests/egl/egl-nok-swap-region.c
> +++ b/tests/egl/egl-nok-swap-region.c
> @@ -28,6 +28,7 @@
>   * Test EGL_NOK_swap_region.
>   */
>
> +#define PFNEGLSWAPBUFFERSREGIONNOK PFNEGLSWAPBUFFERSREGIONNOKPROC
>  #include "piglit-util-gl.h"
>  #include "egl-util.h"
>
> @@ -64,10 +65,10 @@ draw(struct egl_state *state)
>                 { 55, 55, red },
>                 { 55, state->height - 55, green },
>         };
> -       PFNEGLSWAPBUFFERSREGIONNOK swap_buffers_region;
> +       PFNEGLSWAPBUFFERSREGIONNOKPROC swap_buffers_region;
>         int i;
>
> -       swap_buffers_region = (PFNEGLSWAPBUFFERSREGIONNOK)
> +       swap_buffers_region = (PFNEGLSWAPBUFFERSREGIONNOKPROC)
It could be the late hour but things look backwards.
Namely: Using the PROC version yet defining the non-PROC one.

Please don't forget the ifndef PFN... guard.

-Emil


More information about the Piglit mailing list