[Piglit] [PATCH 12/15] squash! shader_runner: add ability to run multiple tests per process

Marek Olšák maraeo at gmail.com
Mon Sep 12 13:36:34 UTC 2016

On Sat, Sep 10, 2016 at 1:33 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> On 09.09.2016 21:18, Dylan Baker wrote:
>> Bug fixes from me for the above patch.
>> I've split these out to make them easier to review. Before merging to
>> master this will be squashed into the previous patch.
>> Changes:
>>  - Fix the assertion of subuniform_locations
>>  - Add teardown function for UBOs that destroys objects and frees memory
>>  - Print 'PIGLIT TEST:' instead of test. This is more likely to be
>>    unique, and is needed by the framework for recovering from crashes
>>  - Print the 'PIGLIT TEST:' line to stderr as well as stdout
>>  - After freeing subuniform_locations also set the values back to NULL
>>  - Add a flag for subtest reporting. This allows the piglit framework to
>>    tell shader_runner that it wants the results as subtest reports, but
>>    allows the current users to continue to get the results the expect
>>    without making any changes. It also covers a few corners of resuming.
>>  - Ensure that shaders are cleaned-up after linking
>>  - call glDisable with GL_TEXTURE_2D
> This must happen for all texture units, and I don't think that's the case
> right now if I'm reading the patch right. It's possible that no existing
> test hits this...

The GL_TEXTURE_2D enable should have no effect on shaders. I'm pretty
sure it has no effect on GLSL.


More information about the Piglit mailing list