[Piglit] [PATCH] cts_gl.py: only generate tests for GL45-CTS

Emil Velikov emil.l.velikov at gmail.com
Tue Sep 13 13:51:46 UTC 2016

On 12 September 2016 at 14:55, Marek Olšák <maraeo at gmail.com> wrote:
> On Mon, Sep 12, 2016 at 3:33 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 9 September 2016 at 14:10, Marek Olšák <maraeo at gmail.com> wrote:
>>> From: Marek Olšák <marek.olsak at amd.com>
>>> Older versions don't work and there is no interest in fixing the official
>>> gl45release CTS branch, so it's useless to add those forever-broken tests.
>> Surely you meant so say s/official gl45release CTS branch/official pre
>> gl45release CTS branches/, right ?
> Yes, I use the branch, not the tarballs.
The focus is on the gl45release vs _pre_ gl45release wording. As-is
you mention there's no interest in fixing the GL45 branch, yet
cts_gl.py is updated to run _only_ GL45 tests. Which in itself is

>> That aside, is the "there is no interest" official statement or your
>> assumption based on the patches needed to get it working ? Guess it's
>> a bit hard to get things going (push fixes to CTS) but not impossible.
> It's my assumption that is highly probable based on the fact that
> there are a bazillion CTS patches being exchanged by mail instead of
> pushing them to the repo.
My humble understanding is that patches/fixes get checked over the
weekly working group meetings. Things can be slow when there is little
documentation (short/missing commit messages anyone?) and/or there is
nobody to put them on the table.

So better yet, attend the respective meetings and help move things forward.

That said, this is not an objection against the patch. But more of
"strive to improve, don't call names" suggestion :-)


More information about the Piglit mailing list