[Piglit] [PATCH] egl-khr-debug: Start adding tests for EGL_KHR_debug

Adam Jackson ajax at redhat.com
Tue Sep 13 15:44:45 UTC 2016

On Mon, 2016-09-12 at 23:21 -0700, Eric Anholt wrote:

> Is one supposed to be used somewhere else?  Is it supposed to have the
> value "1" at some point?

An earlier iteration of this test tried to verify that the label did in
fact change when you changed it. But it did this by trying to
QueryDebug on the thread object, which isn't actually something you can
do, QueryDebug only lets you ask for the enabled level bits and the

It's junk at this point, I'll clean that up.

> ARRAY_SIZE would be nicer here.

Indeed, I keep forgetting that's a thing.

> I think this test would be a lot nicer split into two: One for the basic
> API error checks like labelObject(dpy, EGL_BAD_TOKEN, NULL, ptr) and
> default message contro state that don't seem to be related to the thread
> object, and another for the thread error callback testing.

Makes sense to me, will do.

- ajax

More information about the Piglit mailing list