[Piglit] [PATCH v2 0/2] ARB_compute_variable_group_size

[Samuel Pitoiset]

Ping.

Ian, Nicolai, do you have any comments on that v2?

Thanks.

On 09/10/2016 05:19 PM, Samuel Pitoiset wrote:
> v2: - add glDispatchComputeGroupSizeARB to shader_runner
>     - update formatting spec quotations
>     - add a new test which checks various local sizes
>
> From original cover-letter:
>
> Hi there,
>
> This patch adds some tests for ARB_compute_variable_group_size which is
> written against GL 4.3. All tests pass with NVIDIA blob 370.23 on Fermi.
>
> I'm currently implementing the extension in mesa, most of the tests
> currently pass as well, but adding the new gl_LocalGroupSizeARB compute
> built-in is a bit tricky.
>
> Please review,
> Thanks!
>
> Samuel Pitoiset (2):
>   shader_runner: add support for glDispatchComputeGroupSizeARB()
>   add ARB_compute_variable_group_size tests
>
>  tests/all.py                                       |   8 +
>  tests/shaders/shader_runner.c                      |   7 +
>  tests/spec/CMakeLists.txt                          |   1 +
>  .../CMakeLists.gl.txt                              |  16 ++
>  .../arb_compute_variable_group_size/CMakeLists.txt |   1 +
>  .../compiler/do_nothing.comp                       |  14 +
>  .../compiler/gl_LocalGroupSizeARB_illegal_use.comp |  28 ++
>  .../compiler/gl_LocalGroupSizeARB_layout.comp      |  27 ++
>  .../mixed_fixed_variable_local_work_size.comp      |  23 ++
>  .../spec/arb_compute_variable_group_size/errors.c  | 249 ++++++++++++++++++
>  .../execution/basic-local-size.shader_test         |  31 +++
>  ...ixed_fixed_variable_local_work_size.shader_test |  36 +++
>  .../linker/no_local_size_specified.shader_test     |  32 +++
>  .../arb_compute_variable_group_size/local-size.c   | 283 +++++++++++++++++++++
>  .../spec/arb_compute_variable_group_size/minmax.c  |  65 +++++
>  15 files changed, 821 insertions(+)
>  create mode 100644 tests/spec/arb_compute_variable_group_size/CMakeLists.gl.txt
>  create mode 100644 tests/spec/arb_compute_variable_group_size/CMakeLists.txt
>  create mode 100644 tests/spec/arb_compute_variable_group_size/compiler/do_nothing.comp
>  create mode 100644 tests/spec/arb_compute_variable_group_size/compiler/gl_LocalGroupSizeARB_illegal_use.comp
>  create mode 100644 tests/spec/arb_compute_variable_group_size/compiler/gl_LocalGroupSizeARB_layout.comp
>  create mode 100644 tests/spec/arb_compute_variable_group_size/compiler/mixed_fixed_variable_local_work_size.comp
>  create mode 100644 tests/spec/arb_compute_variable_group_size/errors.c
>  create mode 100644 tests/spec/arb_compute_variable_group_size/execution/basic-local-size.shader_test
>  create mode 100644 tests/spec/arb_compute_variable_group_size/linker/mixed_fixed_variable_local_work_size.shader_test
>  create mode 100644 tests/spec/arb_compute_variable_group_size/linker/no_local_size_specified.shader_test
>  create mode 100644 tests/spec/arb_compute_variable_group_size/local-size.c
>  create mode 100644 tests/spec/arb_compute_variable_group_size/minmax.c
>