[Piglit] [PATCH 2/2] vs-loop-zero-iterations-two-exits2: Use green for pass, red for fail.

Alejandro Piñeiro apinheiro at igalia.com
Wed Sep 28 16:29:18 UTC 2016


Didn't know that there was a standard color-code for this kind of
things. But ok

Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>

On 28/09/16 17:38, Eric Anholt wrote:
> This test was the opposite of standard piglit style, which was a
> surprise.
> ---
>  .../execution/vs-loop-zero-iterations-two-exits2.shader_test      | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/spec/glsl-1.10/execution/vs-loop-zero-iterations-two-exits2.shader_test b/tests/spec/glsl-1.10/execution/vs-loop-zero-iterations-two-exits2.shader_test
> index 4e306527b862..f2ebaf46a2e6 100644
> --- a/tests/spec/glsl-1.10/execution/vs-loop-zero-iterations-two-exits2.shader_test
> +++ b/tests/spec/glsl-1.10/execution/vs-loop-zero-iterations-two-exits2.shader_test
> @@ -13,10 +13,10 @@ void main()
>    /* Make sure that loop_count uniform live */
>    float one = float(loop_count == 0 || loop_count == 1);
>  
> -  vec4 colour = vec4(1.0, 0.0, 0.0, one);
> +  vec4 colour = vec4(0.0, 1.0, 0.0, one);
>  
>    for (int i = 0; i < 0; i++) {
> -     colour = vec4(0.0, 1.0, 0.0, 1.0);
> +     colour = vec4(1.0, 0.0, 0.0, 1.0);
>  
>       if (i == loop_count)
>          break;
> @@ -36,8 +36,8 @@ clear color 0.5 0.5 0.5 0.5
>  
>  uniform int loop_count 1
>  draw rect -1 -1 2 2
> -probe all rgba 1.0 0.0 0.0 1.0
> +probe all rgba 0.0 1.0 0.0 1.0
>  
>  uniform int loop_count 0
>  draw rect -1 -1 2 2
> -probe all rgba 1.0 0.0 0.0 1.0
> +probe all rgba 0.0 1.0 0.0 1.0
> 

-- 
Alejandro Piñeiro <apinheiro at igalia.com>


More information about the Piglit mailing list