[Piglit] [PATCH 1/1] cl: Unmap mapped cl buffer in buffer-flags test

[Jan Vesely]

On Mon, 2017-03-27 at 17:28 -0700, Francisco Jerez wrote:
> Jan Vesely <jan.vesely at rutgers.edu> writes:
> 
> > On Thu, 2017-03-16 at 19:17 -0400, Jan Vesely wrote:
> > > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > > ---
> > >  tests/cl/custom/buffer-flags.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/tests/cl/custom/buffer-flags.c b/tests/cl/custom/buffer-flags.c
> > > index 115fb92..1429de0 100644
> > > --- a/tests/cl/custom/buffer-flags.c
> > > +++ b/tests/cl/custom/buffer-flags.c
> > > @@ -173,6 +173,8 @@ buffer_test(piglit_cl_context *ctx,
> > >  
> > >  	/* cleanup */
> > >  cleanup:
> > > +	if (result != out_buffer)
> > > +		clEnqueueUnmapMemObject(context->command_queues[0], out_buffer, result, 0, NULL, NULL);
> > >  	clReleaseMemObject(in_buffer);
> > >  	clReleaseMemObject(out_buffer);
> > >  	clReleaseKernel(kernel);
> > 
> > ping.
> > this fixes test behaviour that was the motivation for clover pipe
> > reference counting (14b543bd)
> > 
> > are you interested in OCL piglit patches? should I just drop you from
> > cc?
> > 
> 
> I'm not familiar with the code of this piglit test so I cannot give you
> an informed review, but feel free to add my
> 
> Acked-by: Francisco Jerez <currojerez at riseup.net>
> 
> if that's useful to you...

thank you. I ended up not using it, because v2 needed few fixes.

Jan

> 
> > Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170405/6dbaf9b7/attachment.sig>