[Piglit] [PATCH 3/8] arb_tessellation_shader/execution/sanity2: new variant of the test

Marek Olšák maraeo at gmail.com
Tue Apr 11 17:37:58 UTC 2017

On Tue, Apr 11, 2017 at 6:52 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Tue, Apr 11, 2017 at 12:17 PM, Marek Olšák <maraeo at gmail.com> wrote:
>> On Mon, Apr 10, 2017 at 11:12 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>> This appears to be nop.shader_test almost verbatim...
>> But the difference is clear: nop.shader_test ends up using a constant
>> buffer for vertex data, while this tests uses a vertex buffer.
> Ah OK. Well, I don't care that much about the naming, but it just
> seems sad to end up with a bunch of nop/nop2/nop75/etc shaders which
> are all the same but subtly different. I'd recommend trying for a more
> descriptive name. Either way, this seems like a legal test, so
> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

I can rename all the tests to *trivial-*, but I wouldn't bother
sending it to this list.


More information about the Piglit mailing list