[Piglit] [PATCH] arb_separate_shader_objects: Check piglit_link_check_status result.

Samuel Pitoiset samuel.pitoiset at gmail.com
Thu Apr 20 22:20:43 UTC 2017


Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 04/21/2017 12:10 AM, Vinson Lee wrote:
> Fix Coverity unchecked return value defect.
> 
> CID: 743618
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   .../arb_separate_shader_objects/ActiveShaderProgram-invalid-program.c   | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/spec/arb_separate_shader_objects/ActiveShaderProgram-invalid-program.c b/tests/spec/arb_separate_shader_objects/ActiveShaderProgram-invalid-program.c
> index 85eae229ea20..c47b730e9ae8 100644
> --- a/tests/spec/arb_separate_shader_objects/ActiveShaderProgram-invalid-program.c
> +++ b/tests/spec/arb_separate_shader_objects/ActiveShaderProgram-invalid-program.c
> @@ -83,7 +83,7 @@ piglit_init(int argc, char **argv)
>   	(void)!asprintf(&source, vs_code_template, glsl_version);
>   	vs_prog = glCreateShaderProgramv(GL_VERTEX_SHADER, 1,
>   					 (const GLchar *const *) &source);
> -	piglit_link_check_status(vs_prog);
> +	pass = piglit_link_check_status(vs_prog) && pass;
>   
>   	/* First, make a valid program active.
>   	 */
> 


More information about the Piglit mailing list