[Piglit] [PATCH] glsl-1.40: Print the same expected output used in comparison.

Timothy Arceri tarceri at itsqueeze.com
Fri Apr 21 00:59:29 UTC 2017


Acked-by: Timothy Arceri <tarceri at itsqueeze.com>

On 21/04/17 08:55, Vinson Lee wrote:
> Fix Coverity uninitialized scalar variable defect.
> 
> CID: 743760
> Fixes: aa5525e713b6 ("glsl-1.40: Add a test for vertex shaders that don't write gl_Position.")
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   tests/spec/glsl-1.40/tf-no-position.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/spec/glsl-1.40/tf-no-position.c b/tests/spec/glsl-1.40/tf-no-position.c
> index af6b37013b84..85abcc5681b8 100644
> --- a/tests/spec/glsl-1.40/tf-no-position.c
> +++ b/tests/spec/glsl-1.40/tf-no-position.c
> @@ -63,7 +63,6 @@ void piglit_init(int argc, char **argv)
>   	GLuint vs;
>   	GLuint *readback;
>   	GLuint buffer[BUFFER_SIZE];
> -	GLuint expected[BUFFER_SIZE];
>   	int i;
>   	bool pass = true;
>   	GLint input_index;
> @@ -124,8 +123,8 @@ void piglit_init(int argc, char **argv)
>   	/* Check output */
>   	for (i = 0; i < BUFFER_SIZE; ++i) {
>   		if (verts[i] != readback[i]) {
> -			printf("readback[%u]: %u, expected: %u\n", i,
> -			       readback[i], expected[i]);
> +			printf("readback[%u]: %u, verts[%u]: %u\n", i,
> +			       readback[i], i, verts[i]);
>   			pass = false;
>   		}
>   	}
> 


More information about the Piglit mailing list