[Piglit] [PATCH v2] gl-1.0-simple-renderbuffer: add a protection from test failure when an user fbo is defined

[Tapani Pälli]

On 04/25/2017 04:07 PM, sandra koroniewska wrote:
> Thanks, I corrected the condition. Am I allowed to push these changes? 
> I'm quite new here and don't know if I have privilege to do this or if 
> only reviewers can push.
>

I'll push the change. When you have 'enough' commits you can request for 
a push access by filing a bug in freedesktop.org for 'New accounts' 
component IIRC.

> On Tue, Apr 25, 2017 at 2:07 PM, Sandra Koroniewska 
> <sandra.koroniewska at gmail.com <mailto:sandra.koroniewska at gmail.com>> 
> wrote:
>
>     This fixes spec/gl-1.0/simple-readbuffer with the argument "-fbo"
>     according to OpenGL 4.4 spec (page 476).
>     ---
>      tests/spec/gl-1.0/simple-readbuffer.c | 5 ++++-
>      1 file changed, 4 insertions(+), 1 deletion(-)
>
>     diff --git a/tests/spec/gl-1.0/simple-readbuffer.c
>     b/tests/spec/gl-1.0/simple-readbuffer.c
>     index e5b67bf4d..6abe45607 100644
>     --- a/tests/spec/gl-1.0/simple-readbuffer.c
>     +++ b/tests/spec/gl-1.0/simple-readbuffer.c
>     @@ -45,7 +45,10 @@ piglit_display(void)
>      void
>      piglit_init(int argc, char **argv)
>      {
>     -       glReadBuffer(GL_FRONT);
>     +    if (!piglit_use_fbo)
>     +        glReadBuffer(GL_FRONT);
>     +    else
>     +        glReadBuffer(GL_COLOR_ATTACHMENT0);
>
>             if (!piglit_check_gl_error(GL_NO_ERROR)) {
>                     piglit_report_result(PIGLIT_FAIL);
>     --
>     2.11.0.windows.1
>
>
>
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170426/403f56bf/attachment.html>