[Piglit] [PATCH] arb_compute_shader: fix shared-atomics.comp

Samuel Pitoiset samuel.pitoiset at gmail.com
Thu Apr 27 15:26:40 UTC 2017



On 04/27/2017 05:24 PM, Ilia Mirkin wrote:
>  From ARB_compute_shader:
> 
> Dependencies on OpenGL 4.3 and ARB_shader_storage_buffer_object
> 
>      If OpenGL 4.3 and ARB_shader_storage_buffer_object are not supported, the
>      spec language adding the built-in functions atomicAdd(), atomicMin(),
>      atomicMax(), atomicAnd(), atomicOr(), atomicXor(), atomicExchange(), and
>      atomicCompSwap() should be considered to be incorporated into this
>      extension as-is, except that buffer variables will not be supported and
>      thus cannot be used with these functions.  No "#extension" directive is
>      necessary to use these functions in compute shaders.

Ah, I missed that point. Corner case :)

> 
> On Thu, Apr 27, 2017 at 11:19 AM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> atomic*() functions require either GLSL 4.30 or
>> GL_ARB_shader_storage_buffer_object.
>>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> ---
>>   tests/spec/arb_compute_shader/compiler/shared-atomics.comp | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/spec/arb_compute_shader/compiler/shared-atomics.comp b/tests/spec/arb_compute_shader/compiler/shared-atomics.comp
>> index 3835bee03..a4f4a6855 100644
>> --- a/tests/spec/arb_compute_shader/compiler/shared-atomics.comp
>> +++ b/tests/spec/arb_compute_shader/compiler/shared-atomics.comp
>> @@ -6,6 +6,7 @@
>>
>>   #version 420
>>   #extension GL_ARB_compute_shader: enable
>> +#extension GL_ARB_shader_storage_buffer_object : enable
>>
>>   shared uint u;
>>   shared int i;
>> --
>> 2.12.2
>>
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list