[Piglit] [PATCH] gl30basic: add some extra suspected extension

Brian Paul brianp at vmware.com
Fri Aug 4 13:17:30 UTC 2017


I applied your patch and compiled it.  There were compilation warnings 
about passing GLubyte * to strncmp() and strcmp() which expects char *.

I've fixed that, adjusted the formatting and wrapped the lines to 78 
columns.  See attachemnt.  If it looks OK to you, Sanda, I'll push it.

-Brian

On 08/04/2017 05:06 AM, sandra koroniewska wrote:
> Hi,
> thanks for the answer. Then, can anyone review this please?
> It would be a shame if this was not pushed, because a lot of people
> spent their time to comment this patch and WGL_EXT_swap_control is in
> the extension string on Windows Nvidia, AMD and Intel drivers.
>
> Regards,
> Sandra
>
> On Wed, Jul 26, 2017 at 3:50 PM, Martin Peres
> <martin.peres at linux.intel.com <mailto:martin.peres at linux.intel.com>> wrote:
>
>     On 26/07/17 15:58, sandra koroniewska wrote:
>
>         Hello,
>         is this patch ok now? Because it hasn't been pushed.
>
>         Regards,
>         Sandra
>
>
>     It still did not get any Reviewed-by. I guess the summer vacation is
>     affecting the piglit team.
>
>
>
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gl30basic-add-some-extra-suspected-extension.patch
Type: text/x-patch
Size: 1459 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170804/872bb99b/attachment.bin>


More information about the Piglit mailing list