[Piglit] [PATCH] egl_khr_fence_sync: don't require ES3 support

Tapani Pälli tapani.palli at intel.com
Mon Dec 11 06:41:33 UTC 2017



On 12/02/2017 03:06 AM, Stefan Schake wrote:
> Bits in EGL_RENDERABLE_TYPE act as ANDs. Since we only create ES2 contexts,
> we can drop the requirement for ES3 context support.

Yes, ES3 is not needed. Actually the whole config_attribs is useless. My 
suggestion is to just remove the whole thing and pass NULL instead of 
config_attribs for eglChooseConfig.

> Signed-off-by: Stefan Schake <stschake at gmail.com>
> ---
>   tests/egl/spec/egl_khr_fence_sync/egl_khr_fence_sync.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/egl/spec/egl_khr_fence_sync/egl_khr_fence_sync.c b/tests/egl/spec/egl_khr_fence_sync/egl_khr_fence_sync.c
> index dcd56cf..6c6931e 100644
> --- a/tests/egl/spec/egl_khr_fence_sync/egl_khr_fence_sync.c
> +++ b/tests/egl/spec/egl_khr_fence_sync/egl_khr_fence_sync.c
> @@ -130,7 +130,7 @@ init_context(EGLDisplay dpy, EGLContext *out_ctx)
>   	EGLint num_configs = 0;
>   	EGLContext ctx = 0;
>   
> -	/* Create OpenGL ES 2.0 or backwards-compatible context. */
> +	/* Create OpenGL ES 2.0 context. */
>   	static const EGLint config_attribs[] = {
>   		EGL_RED_SIZE,		EGL_DONT_CARE,
>   		EGL_GREEN_SIZE,		EGL_DONT_CARE,
> @@ -138,8 +138,7 @@ init_context(EGLDisplay dpy, EGLContext *out_ctx)
>   		EGL_ALPHA_SIZE,		EGL_DONT_CARE,
>   		EGL_DEPTH_SIZE, 	EGL_DONT_CARE,
>   		EGL_STENCIL_SIZE, 	EGL_DONT_CARE,
> -		EGL_RENDERABLE_TYPE, 	EGL_OPENGL_ES2_BIT
> -				        | EGL_OPENGL_ES3_BIT_KHR,
> +		EGL_RENDERABLE_TYPE, 	EGL_OPENGL_ES2_BIT,
>   		EGL_NONE,
>   	};
>   
> 


More information about the Piglit mailing list