[Piglit] [PATCH 2/4] ext_memory_object: remove redundant print on failure

Andres Rodriguez andresx7 at gmail.com
Fri Dec 22 00:35:27 UTC 2017


Calling piglit_check_gl_error() already dumps the relevant debug
information to stdout.

Signed-off-by: Andres Rodriguez <andresx7 at gmail.com>
---
 tests/spec/ext_memory_object/api-errors.c | 21 +++------------------
 1 file changed, 3 insertions(+), 18 deletions(-)

diff --git a/tests/spec/ext_memory_object/api-errors.c b/tests/spec/ext_memory_object/api-errors.c
index 8cd197f..15b4b1c 100644
--- a/tests/spec/ext_memory_object/api-errors.c
+++ b/tests/spec/ext_memory_object/api-errors.c
@@ -84,12 +84,7 @@ test_tex_storage_errors(GLenum target, bool dsa)
 	 *
 	 *    "An INVALID_VALUE error is generated if <memory> is 0 ..."
 	 */
-	if (!piglit_check_gl_error(GL_INVALID_VALUE)) {
-		printf("Fail: GL_INVALID_VALUE expected\n");
-		return false;
-	}
-
-	return true;
+	return piglit_check_gl_error(GL_INVALID_VALUE);
 }
 
 static bool
@@ -134,12 +129,7 @@ test_tex_storage_ms_errors(GLenum target, bool dsa)
 	 *
 	 *    "An INVALID_VALUE error is generated if <memory> is 0 ..."
 	 */
-	if (!piglit_check_gl_error(GL_INVALID_VALUE)) {
-		printf("Fail: GL_INVALID_VALUE expected\n");
-		return false;
-	}
-
-	return true;
+	return piglit_check_gl_error(GL_INVALID_VALUE);
 }
 
 #define BUF_SIZE (12 * 4 * sizeof(float))
@@ -163,12 +153,7 @@ test_buffer_storage_errors(bool dsa)
 	 *
 	 *    "An INVALID_VALUE error is generated if <memory> is 0 ..."
 	 */
-	if (!piglit_check_gl_error(GL_INVALID_VALUE)) {
-		printf("Fail: GL_INVALID_VALUE expected\n");
-		return false;
-	}
-
-	return true;
+	return piglit_check_gl_error(GL_INVALID_VALUE);
 }
 
 #define X(f, desc)					     	\
-- 
2.9.3



More information about the Piglit mailing list