[Piglit] [PATCH 1/2] framework: handle UnicodeDecodeError

Dylan Baker dylan at pnwbakers.com
Mon Feb 6 22:10:17 UTC 2017


I'm curious when you're hitting this because while this works around the problem
it's not really fixing it, and I'd really like to fix it correctly.

In the meantime I'm okay with this change:
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

Quoting Marek Olšák (2017-02-05 11:28:41)
> From: Marek Olšák <marek.olsak at amd.com>
> 
> this happened to me once
> ---
>  framework/test/base.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/framework/test/base.py b/framework/test/base.py
> index 4e7c8b2..756b08a 100644
> --- a/framework/test/base.py
> +++ b/framework/test/base.py
> @@ -356,20 +356,22 @@ class Test(object):
>                  os.killpg(os.getpgid(proc.pid), signal.SIGKILL)
>  
>              # Since the process isn't running it's safe to get any remaining
>              # stdout/stderr values out and store them.
>              self.result.out, self.result.err = proc.communicate()
>  
>              raise TestRunError(
>                  'Test run time exceeded timeout value ({} seconds)\n'.format(
>                      self.timeout),
>                  'timeout')
> +        except UnicodeDecodeError as e:
> +            raise TestRunError("UnicodeDecodeError.\n", 'crash')
>  
>          # The setter handles the bytes/unicode conversion
>          self.result.out = out
>          self.result.err = err
>          self.result.returncode = returncode
>  
>      def __eq__(self, other):
>          return self.command == other.command
>  
>      def __ne__(self, other):
> -- 
> 2.7.4
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170206/0bbe0acd/attachment.sig>


More information about the Piglit mailing list