[Piglit] [PATCH 0/2] Preserve the testrun test order
dylan at pnwbakers.com
Thu Feb 9 17:35:43 UTC 2017
One more minor thing I noticed, you probably should change the name of the
author in git from "Fi Jenkins" to your actual name :)
Quoting Tomi Sarvela (2017-02-09 03:07:03)
> One test can mess with the state of the machine and cause
> later tests to fail. Because of this, the testing order found
> in the report should reflect the actual testing order, in
> order to identify the test that has messed up the state.
> There has been some effort to preserve order internally
> (OrderedDict used in some places), but not consistently.
> This patch makes preservation of the test order within
> testrun explicit:
> . use OrderedDict comprehension when copying 'tests'
> . read files from tests-dir in numerical order
> . use OrderedDict instead of dict when necessary
> Style-question: Instead of collections.OrderedDict, I've
> used narrower import and OrderedDict. Which way would be
> preferred here?
> Any comments welcome!
> Tomi Sarvela (2):
> framework/results.py: Copy 'tests' internally to OrderedDict
> framework/backends/json.py: preserve 'tests' order
> framework/backends/json.py | 42 +++++++++++++++++++++++++++++-------------
> framework/results.py | 16 +++++++++-------
> 2 files changed, 38 insertions(+), 20 deletions(-)
> Piglit mailing list
> Piglit at lists.freedesktop.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 488 bytes
More information about the Piglit