[Piglit] [PATCH] arb_get_texture_sub_image-errors: Fix expected error values

Eduardo Lima Mitev elima at igalia.com
Wed Feb 15 18:35:34 UTC 2017


glGetTextureSubImage() and glGetCompressedTextureSubImage() return
GL_INVALID_VALUE instead of GL_INVALID_OPERATION when the 'texture'
argument does not correspond to an existing texture object.

>From OpenGL 4.5 spec PDF, section '8.11. Texture Queries', page 236:

    "An INVALID_VALUE error is generated if texture is not the name of
     an existing texture object."
---
 tests/spec/arb_get_texture_sub_image/errors.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/spec/arb_get_texture_sub_image/errors.c b/tests/spec/arb_get_texture_sub_image/errors.c
index 8eb005e61..0a662ee23 100644
--- a/tests/spec/arb_get_texture_sub_image/errors.c
+++ b/tests/spec/arb_get_texture_sub_image/errors.c
@@ -46,7 +46,7 @@ test_texture_id(void)
 			     8, 8, 1, /* size */
 			     GL_RGBA, GL_UNSIGNED_BYTE,
 			     sizeof(buffer), buffer);
-	if (!piglit_check_gl_error(GL_INVALID_OPERATION))
+	if (!piglit_check_gl_error(GL_INVALID_VALUE))
 		pass = false;
 
 	/* Test compressed get with bad texture ID */
@@ -54,7 +54,7 @@ test_texture_id(void)
 				       0, 0, 0, /* offset */
 				       8, 8, 1, /* size */
 				       sizeof(buffer), buffer);
-	if (!piglit_check_gl_error(GL_INVALID_OPERATION))
+	if (!piglit_check_gl_error(GL_INVALID_VALUE))
 		pass = false;
 
 	/* Test get with undefined texture */
-- 
2.11.0



More information about the Piglit mailing list