[Piglit] [PATCH] builtin_functions: Add more 64-bit integers
Lionel Landwerlin
lionel.g.landwerlin at intel.com
Fri Feb 24 15:01:33 UTC 2017
I thought these would have been caught by gen_conversion.py :/
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
On 24/02/17 01:20, Jason Ekstrand wrote:
> Seriously, 100000000000 is not the only 64-bit integer. We should test
> a few more of them.
>
> These new integers trigger a bug in the GLSL IR int64 lowering code.
>
> Cc: Ian Romanick <ian.d.romanick at intel.com>
> ---
> generated_tests/builtin_function.py | 24 ++++++++++++++++++++++--
> 1 file changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/generated_tests/builtin_function.py b/generated_tests/builtin_function.py
> index 663d9d8..a5eafb2 100644
> --- a/generated_tests/builtin_function.py
> +++ b/generated_tests/builtin_function.py
> @@ -1309,8 +1309,28 @@ def _make_vector_or_matrix_test_vectors(test_suite_dict):
> [ 0.14, 0.18, -0.56],
> [ 0.40, -0.77, 1.76]]), # mat3x4
> ]
> - int64s = [np.int64(x) for x in [0, -100000000000, 100000000000]]
> - uint64s = [np.uint64(x) for x in [0, 10, 100000000000]]
> +
> + int64s = [np.int64(x) for x in [
> + 0,
> + 3,
> + -1192,
> + 1048576,
> + 4251475,
> + 29852643761,
> + -4398046511104,
> + -3948976685146,
> + -135763469567146206]]
> + uint64s = [np.uint64(x) for x in [
> + 0,
> + 3,
> + 1192,
> + 1048576,
> + 4251475,
> + 29852643761,
> + 4398046511104,
> + 3948976685146,
> + 135763469567146206,
> + 11654173250180970009]]
>
> int64vecs = [
> np.array([-10, -12], dtype=np.int64),
More information about the Piglit
mailing list