[Piglit] [PATCH 08/10] cl: Add tests for mul24 and mulhi 24 bit optimizations

Jan Vesely jan.vesely at rutgers.edu
Tue Feb 28 00:58:10 UTC 2017


resending trimmed to appease the ML

On Mon, 2017-02-27 at 16:26 -0500, Jan Vesely wrote:
> On Thu, 2017-02-02 at 01:16 -0800, Matt Arsenault wrote:
> > > On Dec 8, 2016, at 16:21, Jan Vesely <jan.vesely at rutgers.edu> wrote:
> > > 
> > > On Mon, 2016-12-05 at 09:48 -0800, arsenm2 at gmail.com <mailto:arsenm2 at gmail.com> wrote:
> > > > From: Matt Arsenault <arsenm2 at gmail.com>

[SNIP]

> > > 
> > > any reason why these are in a separate file rather than extending
> > > scalar_arithmetic_${TYPE} tests?
> > > 
> > > Jan
> > 
> > These aren’t testing that a basic operation is working, and are
> > aiming at specific optimizations. 
> 
> ok, I guess custom kernels make it different enough.
> 
> Reviewed-by: Jan Vesely <jan.vesely at rutgers.edu>
> 
> I still don't like the idea of dumping 1000s of test lines into piglit.
> especially if it's generated it'd be nicer to have the generator
> instead.
> 
> Jan
> 
> PS: feel free to ping other patches that I missed
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170227/009ef54e/attachment.sig>


More information about the Piglit mailing list