[Piglit] [PATCH 1/3] PNG files, write mode correction

[Lionel Landwerlin]

Oh thanks, sorry I had no idea :)

On 10/01/17 14:50, Olender, Sebastian D wrote:
> I'm running this on windows
>
> -----Original Message-----
> From: Landwerlin, Lionel G
> Sent: Tuesday, January 10, 2017 3:48 PM
> To: Olender, Sebastian D <sebastian.d.olender at intel.com>; piglit at lists.freedesktop.org
> Subject: Re: [Piglit] [PATCH 1/3] PNG files, write mode correction
>
> The man page of fopen says :
>
> "This is strictly for compatibility with C89 and has no effect; the 'b'
> is ignored on all POSIX conforming systems, including Linux."
>
> I don't know where you're running this, but sure :)
>
> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>
> On 10/01/17 14:38, Sebastian Olender wrote:
>> Signed-off-by: Sebastian Olender <sebastian.d.olender at intel.com>
>> ---
>>    tests/util/piglit-util-png.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/util/piglit-util-png.c
>> b/tests/util/piglit-util-png.c index 4835ed6..c63ec7b 100644
>> --- a/tests/util/piglit-util-png.c
>> +++ b/tests/util/piglit-util-png.c
>> @@ -87,7 +87,7 @@ piglit_write_png(const char *filename,
>>    		break;
>>    	}
>>    
>> -	fp = fopen(filename, "w");
>> +	fp = fopen(filename, "wb");
>>    	if (!fp)
>>    		abortf("failed to open `%s'", filename);
>>    
>