[Piglit] [PATCH v3] egl: test that EGL_BAD_PARAMETER is returned for an invalid EGLImage attrib

[Emil Velikov]

On 11 January 2017 at 21:27, Micah Fedke <micah.fedke at collabora.co.uk> wrote:
> This tests the following statement from EGL_KHR_image_base.txt:
> If an attribute specified in <attrib_list> is not one of the attributes
> listed in Table bbb, the error EGL_BAD_PARAMETER is generated.
>
> Signed-off-by: Micah Fedke <micah.fedke at collabora.co.uk>
> ---
>  tests/all.py                 |   2 +
>  tests/egl/CMakeLists.gl.txt  |   2 +
>  tests/egl/egl-invalid-attr.c | 102 +++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 106 insertions(+)
>  create mode 100644 tests/egl/egl-invalid-attr.c
>
> diff --git a/tests/all.py b/tests/all.py
> index e8de1b2..e1fcd63 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -4505,6 +4505,8 @@ with profile.test_list.group_manager(
>      g(['egl-create-largest-pbuffer-surface'],
>        'largest possible eglCreatePbufferSurface and then glClear',
>        run_concurrent=False)
> +    g(['egl-invalid-attr'],
> +      run_concurrent=True)
>
run_concurrent=True is the default, so one may drop the line.

> new file mode 100644
> index 0000000..08ac10b
> --- /dev/null
> +++ b/tests/egl/egl-invalid-attr.c

> +
> +#include <unistd.h>
> +#include <drm_fourcc.h>
> +
Did not see these before - they should be dropped. Barring any
objections I'll address the above nitpicks and merge the patch in a
day or two.

If someone beats me to it:
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil