[Piglit] [PATCH 0/5] Add int64 conversion tests

Nicolai Hähnle nhaehnle at gmail.com
Tue Jan 31 11:46:24 UTC 2017


On 30.01.2017 19:12, Dylan Baker wrote:
> I haven't looked to closely yet, though I'm planning to do so today or tomorrow.
>
> I do have one question, does this change the names of the fp64 tests? That would
> be less than ideal for us because of our CI system.

No, it doesn't. I used diff (hopefully correctly) to check that the only 
change is an addition of new generated tests. All the previously 
generated tests are unchanged (in file names and contents).

Cheers,
Nicolai

> Dylan
>
> Quoting Nicolai Hähnle (2017-01-26 10:59:21)
>> Hi all,
>>
>> increase the test coverage of GL_ARB_gpu_shader_int64 by testing various
>> conversions. To avoid reinventing the wheel or duplicating code, I've
>> extended the existing fp64 conversion test generation. The first couple
>> of patches simply move code around and rename things. The last patch adds
>> all the actual int64 tests.
>>
>> I verified using diff that the existing generated test files remain
>> unmodified. The only change is that more test files are generated in
>> spec/arb_gpu_shader_int64. Tested against radeonsi with the remaining
>> patches that I'm about to send to mesa-dev. Please review!
>>
>> Thanks,
>> Nicolai
>>
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/piglit



More information about the Piglit mailing list