[Piglit] [PATCH v2] cl: Guard against CL version overflow.

Vinson Lee vlee at freedesktop.org
Tue Jul 25 00:09:37 UTC 2017


Fix Coverity overflowed return value defect.

CID: 1364163
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
---
 tests/util/piglit-framework-cl.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/util/piglit-framework-cl.c b/tests/util/piglit-framework-cl.c
index 235f160877cf..758508ff902f 100644
--- a/tests/util/piglit-framework-cl.c
+++ b/tests/util/piglit-framework-cl.c
@@ -450,6 +450,7 @@ piglit_cl_get_version_arg(int argc, const char** argv)
 {
 	int version_major = 0;
 	int version_minor = 0;
+	int version = 0;
 
 	const char* version_str;
 
@@ -466,7 +467,9 @@ piglit_cl_get_version_arg(int argc, const char** argv)
 		}
 	}
 
-	return version_major*10 + version_minor;
+	version = version_major*10 + version_minor;
+	assert(version > 0);
+	return version;
 }
 
 bool
-- 
2.11.0



More information about the Piglit mailing list