[Piglit] [PATCH v2] cl: Guard against CL version overflow.

[Brian Paul]

On 07/24/2017 06:09 PM, Vinson Lee wrote:
> Fix Coverity overflowed return value defect.
>
> CID: 1364163
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   tests/util/piglit-framework-cl.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/util/piglit-framework-cl.c b/tests/util/piglit-framework-cl.c
> index 235f160877cf..758508ff902f 100644
> --- a/tests/util/piglit-framework-cl.c
> +++ b/tests/util/piglit-framework-cl.c
> @@ -450,6 +450,7 @@ piglit_cl_get_version_arg(int argc, const char** argv)
>   {
>   	int version_major = 0;
>   	int version_minor = 0;
> +	int version = 0;
>
>   	const char* version_str;
>
> @@ -466,7 +467,9 @@ piglit_cl_get_version_arg(int argc, const char** argv)
>   		}
>   	}
>
> -	return version_major*10 + version_minor;
> +	version = version_major*10 + version_minor;
> +	assert(version > 0);
> +	return version;
>   }
>
>   bool
>

I'm kind of surprised by that warning.  By that example, it would seem 
that almost any function which does integer arithmetic would be flagged.

Reviewed-by: Brian Paul <brianp at vmware.com>