[Piglit] [PATCH] gl30basic: add some extra suspected extension

[sandra koroniewska]

Hello,
is this patch ok now? Because it hasn't been pushed.

Regards,
Sandra

On Thu, Jul 20, 2017 at 12:12 PM, sandra koroniewska <
sandra.koroniewska at gmail.com> wrote:

> Hi,
> if this patch is alright now, can someone push it please?
>
> Regards,
> Sandra
>
> On Fri, Jun 30, 2017 at 4:45 PM, sandra koroniewska <
> sandra.koroniewska at gmail.com> wrote:
>
>> "Is it WGL_EXT_SWAP_CONTROL or WGL_EXT_swap_control? I assume you
>> tested this, so it's the latter (as that's what's in the code)."
>>
>> Yes, it's the latter.
>>
>> On Fri, Jun 30, 2017 at 4:40 PM, Sandra Koroniewska <
>> sandra.koroniewska at gmail.com> wrote:
>>
>>> WGL_EXT_SWAP_CONTROL is added for historical reasons.
>>> ---
>>>  tests/general/gl30basic.c | 12 ++++++------
>>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/tests/general/gl30basic.c b/tests/general/gl30basic.c
>>> index 2207787bb..6e1d903dd 100644
>>> --- a/tests/general/gl30basic.c
>>> +++ b/tests/general/gl30basic.c
>>> @@ -95,12 +95,12 @@ test_extension_list(void)
>>>        const GLubyte *ext = glGetStringi(GL_EXTENSIONS, k);
>>>        if (0)
>>>           printf("Ext[%d] = %s\n", k, (char *) ext);
>>> -      if (!ext ||
>>> -          ext[0] != 'G' ||
>>> -          ext[1] != 'L' ||
>>> -          ext[2] != '_') {
>>> -         printf("%s: bad extension string [%d]: %s\n", Prog, k, ext);
>>> -         return PIGLIT_FAIL;
>>> +
>>> +      /* In some drivers WGL_EXT_swap_control is in the extension
>>> +       * string for historical reasons. */
>>> +      if (!ext || (strncmp(ext, "GL_", 3) != 0 && strcmp(ext,
>>> "WGL_EXT_swap_control") != 0)) {
>>> +          printf("%s: bad extension string [%d]: %s\n", Prog, k, ext);
>>> +          return PIGLIT_FAIL;
>>>        }
>>>        if (strchr((char *) ext, ' ')) {
>>>           printf("%s: extension string [%d] contains a space: %s\n",
>>> Prog, k, ext);
>>> --
>>> 2.11.0.windows.1
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170726/0edc53fb/attachment.html>