[Piglit] [Bug 101358] New: piglit_drm_dma_buf.c:265:12: error: ‘GBM_FORMAT_R8’ undeclared

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=101358

            Bug ID: 101358
           Summary: piglit_drm_dma_buf.c:265:12: error: ‘GBM_FORMAT_R8’
                    undeclared
           Product: piglit
           Version: unspecified
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Keywords: bisected, regression
          Severity: normal
          Priority: medium
         Component: tests
          Assignee: piglit at lists.freedesktop.org
          Reporter: vlee at freedesktop.org
        QA Contact: piglit at lists.freedesktop.org
                CC: baker.dylan.c at gmail.com, jan.vesely at rutgers.edu

piglit: bc6ef16dfa432c181e3c0e44223a651e3ea50f76 (master)
libgbm-dev: 12.0.6-0ubuntu0.16.10.1

[  0%] Building C object
target_api/gl/tests/util/CMakeFiles/piglitutil_gl.dir/piglit-framework-gl/piglit_drm_dma_buf.c.o
piglit/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c: In function
‘piglit_gbm_buf_create’:
piglit/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c:265:12: error:
‘GBM_FORMAT_R8’ undeclared (first use in this function)
   format = GBM_FORMAT_R8;
            ^~~~~~~~~~~~~
piglit/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c:265:12: note: each
undeclared identifier is reported only once for each function it appears in
piglit/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c:271:12: error:
‘GBM_FORMAT_GR88’ undeclared (first use in this function)
   format = GBM_FORMAT_GR88;
            ^~~~~~~~~~~~~~~


Build error introduced with this commit.

commit 2217871ac93765a0722c77427d5880154ae91ef9
Author: Daniel Diaz <daniel.diaz at linaro.org>
Date:   Tue May 16 19:06:40 2017 -0500

    CMake: define GBM_BO_MAP only when symbol is found

    gbm_bo_map() and _unmap() have been added recently to Mesa,
    and this update may not have reached all implementations of
    GBM, such as the one provided by Mali r6, where said
    definitions can be found in the header file but not in the
    library itself. This leads to errors like the following when
    linking:
      ../../../../lib/libpiglitutil_gl.so.0: undefined reference to
`gbm_bo_unmap'
      ../../../../lib/libpiglitutil_gl.so.0: undefined reference to
`gbm_bo_map'
      collect2: error: ld returned 1 exit status
      make[2]: *** [bin/point-sprite] Error 1

    Instead of relying on the header file, actually try to link
    using that symbol to determine if PIGLIT_HAS_GBM_BO_MAP
    should be defined.

    Signed-off-by: Daniel Díaz <daniel.diaz at linaro.org>
    Reviewed-by: Jan Vesely <jan.vesely at rutgers.edu>
    Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170608/f99380bd/attachment.html>