[Piglit] [PATCH 1/7] appveyro: Remove help invocation from cmake

Jose Fonseca jfonseca at vmware.com
Wed Jun 14 20:00:07 UTC 2017


I see.  Fair enough.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>

Jose

On 14/06/17 19:01, Dylan Baker wrote:
> According to the man page (for 3.8.2):
> 
>         --help,-help,-usage,-h,-H,/?
>                Print usage information and exit.
> 
>                Usage describes the basic command line interface and its options.
> 
> And I saw this behavior, without removing the -H option no build direcotry was
> created and ninja failed complaining "no such directory build"
> 
> Dylan
> 
> 
> Quoting Jose Fonseca (2017-06-13 14:28:22)
>> -H is not the help option.  Is the source directory.
>>
>>
>> See https://stackoverflow.com/questions/31090821/
>> what-does-the-h-option-means-for-cmake
>>
>>
>> I know that both -B and -H  are undocumented, but I've been using both since
>> forever, since I prefer them to passing the source/dir as positional arguments
>> in the end.
>>
>> Jose
>>
>> ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
>> From: Dylan Baker <dylan at pnwbakers.com>
>> Sent: Tuesday, June 13, 2017 21:59
>> To: piglit at lists.freedesktop.org
>> Cc: Jose Fonseca
>> Subject: [PATCH 1/7] appveyro: Remove help invocation from cmake
>>   
>> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
>> ---
>>   appveyor.yml | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/appveyor.yml b/appveyor.yml
>> index 302308599..00b5700c6 100644
>> --- a/appveyor.yml
>> +++ b/appveyor.yml
>> @@ -86,7 +86,7 @@ install:
>>   - appveyor DownloadFile https://www.khronos.org/registry/OpenGL/api/GL/glext.h
>> -FileName glext\GL\glext.h
>>   
>>   build_script:
>> -- cmake -H. -Bbuild -G "Ninja" -DGLUT_INCLUDE_DIR=%CD%\freeglut\include
>> -DGLUT_glut_LIBRARY=%CD%\freeglut\%FREEGLUT_LIB% -DGLEXT_INCLUDE_DIR=%CD%\glext
>> +- cmake . -Bbuild -G "Ninja" -DGLUT_INCLUDE_DIR=%CD%\freeglut\include
>> -DGLUT_glut_LIBRARY=%CD%\freeglut\%FREEGLUT_LIB% -DGLEXT_INCLUDE_DIR=%CD%\glext
>>   - ninja -C build
>>   
>>   
>> --
>> 2.13.1



More information about the Piglit mailing list