[Piglit] [PATCH 3/3] arb_gpu_shader5: interpolateAt* must reject inputs in structs

Timothy Arceri tarceri at itsqueeze.com
Mon Jun 19 01:01:08 UTC 2017


Can we add a spec quote to these? Otherwise series:

Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

On 17/06/17 06:34, Nicolai Hähnle wrote:
> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
> 
> ---
>   .../fs-interpolateAtCentroid-struct.frag                | 17 +++++++++++++++++
>   .../fs-interpolateAtOffset-struct.frag                  | 17 +++++++++++++++++
>   .../fs-interpolateAtSampler-struct.frag                 | 17 +++++++++++++++++
>   3 files changed, 51 insertions(+)
>   create mode 100644 tests/spec/arb_gpu_shader5/compiler/builtin-functions/fs-interpolateAtCentroid-struct.frag
>   create mode 100644 tests/spec/arb_gpu_shader5/compiler/builtin-functions/fs-interpolateAtOffset-struct.frag
>   create mode 100644 tests/spec/arb_gpu_shader5/compiler/builtin-functions/fs-interpolateAtSampler-struct.frag
> 
> diff --git a/tests/spec/arb_gpu_shader5/compiler/builtin-functions/fs-interpolateAtCentroid-struct.frag b/tests/spec/arb_gpu_shader5/compiler/builtin-functions/fs-interpolateAtCentroid-struct.frag
> new file mode 100644
> index 0000000..453c2db
> --- /dev/null
> +++ b/tests/spec/arb_gpu_shader5/compiler/builtin-functions/fs-interpolateAtCentroid-struct.frag
> @@ -0,0 +1,17 @@
> +// [config]
> +// expect_result: fail
> +// glsl_version: 1.50
> +// require_extensions: GL_ARB_gpu_shader5
> +// [end config]
> +
> +#version 150
> +#extension GL_ARB_gpu_shader5: require
> +
> +in struct {
> +   vec4 a;
> +} a;
> +
> +void main()
> +{
> +   interpolateAtCentroid(a.a);
> +}
> diff --git a/tests/spec/arb_gpu_shader5/compiler/builtin-functions/fs-interpolateAtOffset-struct.frag b/tests/spec/arb_gpu_shader5/compiler/builtin-functions/fs-interpolateAtOffset-struct.frag
> new file mode 100644
> index 0000000..9b7ee7e
> --- /dev/null
> +++ b/tests/spec/arb_gpu_shader5/compiler/builtin-functions/fs-interpolateAtOffset-struct.frag
> @@ -0,0 +1,17 @@
> +// [config]
> +// expect_result: fail
> +// glsl_version: 1.50
> +// require_extensions: GL_ARB_gpu_shader5
> +// [end config]
> +
> +#version 150
> +#extension GL_ARB_gpu_shader5: require
> +
> +in struct {
> +   vec4 a;
> +} a;
> +
> +void main()
> +{
> +   interpolateAtOffset(a.a, vec2(0));
> +}
> diff --git a/tests/spec/arb_gpu_shader5/compiler/builtin-functions/fs-interpolateAtSampler-struct.frag b/tests/spec/arb_gpu_shader5/compiler/builtin-functions/fs-interpolateAtSampler-struct.frag
> new file mode 100644
> index 0000000..78a844e
> --- /dev/null
> +++ b/tests/spec/arb_gpu_shader5/compiler/builtin-functions/fs-interpolateAtSampler-struct.frag
> @@ -0,0 +1,17 @@
> +// [config]
> +// expect_result: fail
> +// glsl_version: 1.50
> +// require_extensions: GL_ARB_gpu_shader5
> +// [end config]
> +
> +#version 150
> +#extension GL_ARB_gpu_shader5: require
> +
> +in struct {
> +   vec4 a;
> +} a;
> +
> +void main()
> +{
> +   interpolateAtSample(a.a, 0);
> +}
> 


More information about the Piglit mailing list