[Piglit] [PATCH 3/3] glx/glx-multithread-texture: Use larger color differences

Brian Paul brianp at vmware.com
Wed Jun 21 15:18:17 UTC 2017


On 06/21/2017 06:25 AM, Thomas Hellstrom wrote:
> Color spacing of 1 between consecutive textures may yield false positives
> when probing, and defer error reporting to the transition from color 255 to
> color 0. That may be confusing. So increase the color spacing to detect
> errors earlier.
>
> Cc: Frank Henigman <fjhenigman at google.com>
> Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
> ---
>   tests/glx/glx-multithread-texture.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/glx/glx-multithread-texture.c b/tests/glx/glx-multithread-texture.c
> index 08121e3..a70d246 100644
> --- a/tests/glx/glx-multithread-texture.c
> +++ b/tests/glx/glx-multithread-texture.c
> @@ -107,7 +107,7 @@ load_func(void *arg)
>   	glEnable(GL_TEXTURE_2D);
>
>   	while (!quit && count <= num_test) {
> -		int color = count & 0xff;
> +		int color = (3 * count) & 0xff;
>
>   		assert(tex->user == LOAD);
>   		if (tex->color != color) {
>

I haven't studied the details of this test, but that looks OK.

Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the Piglit mailing list