[Piglit] [PATCH] piglit_drm_dma_buf: fix GPU offsets and strides

Jan Vesely jan.vesely at rutgers.edu
Wed Jun 21 16:00:49 UTC 2017

On Mon, 2017-06-19 at 16:22 -0700, Eric Anholt wrote:
> Marek Olšák <maraeo at gmail.com> writes:
> > From: Marek Olšák <marek.olsak at amd.com>
> > 
> > Most of the original code is simply wrong.
> > 
> > This patch makes sure that at least the returned GPU offsets and strides
> > are correct. This doesn't fix the incorrect CPU upload path for non-zero
> > planes. GBM doesn't seem to have the capability to map a specific plane
> > for CPU access.
> Reviewed-by: Eric Anholt <eric at anholt.net>

This patch breaks build using older mesa/gbm:
$ rpm -q mesa-libgbm-devel

/usr/bin/cc -I/home/vesely/mesa/include -Wall -std=gnu99 -Werror=vla
-Werror=pointer-arith -Werror=variadic-macros -g  -rdynamic
CMakeFiles/point-sprite.dir/point-sprite.c.o  -o ../../../../bin/point-
sprite -Wl,-rpath,/home/vesely/piglit/lib::
../../../../lib/libpiglitutil_gl.so.0 -lGL
../../../../lib/libpiglitutil.so.0 -lrt -ldl -lxkbcommon -lpng -lz -lm
-lEGL -lgbm -lwaffle-1 -ldrm -lxcb -lxcb-dri2 -ldrm_intel -ldrm -lxcb
-lxcb-dri2 -ldrm_intel -lX11 -lwayland-egl -lwayland-client -lGL 
../../../../lib/libpiglitutil_gl.so.0: undefined reference to
../../../../lib/libpiglitutil_gl.so.0: undefined reference to
collect2: error: ld returned 1 exit status

looks like the used functions were added in 17.1, so this needs to bump
gbm requirement (or check for those functions explicitly).


> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170621/c74033c9/attachment.sig>

More information about the Piglit mailing list