[Piglit] [PATCH] Revert "arb_get_texture_sub_image-errors: Fix expected error values"

Juan A. Suarez Romero jasuarez at igalia.com
Thu Jun 22 15:50:34 UTC 2017


In commit aec149c we test that glGetTextureSubImage() and
glGetCompressedTextureSubImage() returns INVALID_VALUE when the texture
is not the name of an existing texture object.

Nevertheless, this is a bug in the OpenGL 4.5 spec itself, that has been
fixed, but not released yet.

In the fix the expected error value for this case is INVALID_OPERATION.

This reverts commit aec149c836bcd29d4764c8f459fdc45613d18c8c.
---
 tests/spec/arb_get_texture_sub_image/errors.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/spec/arb_get_texture_sub_image/errors.c b/tests/spec/arb_get_texture_sub_image/errors.c
index e6f7972..34fec4a 100644
--- a/tests/spec/arb_get_texture_sub_image/errors.c
+++ b/tests/spec/arb_get_texture_sub_image/errors.c
@@ -47,7 +47,7 @@ test_texture_id(void)
 			     8, 8, 1, /* size */
 			     GL_RGBA, GL_UNSIGNED_BYTE,
 			     sizeof(buffer), buffer);
-	if (!piglit_check_gl_error(GL_INVALID_VALUE))
+	if (!piglit_check_gl_error(GL_INVALID_OPERATION))
 		pass = false;
 
 	/* Test compressed get with bad texture ID */
@@ -55,7 +55,7 @@ test_texture_id(void)
 				       0, 0, 0, /* offset */
 				       8, 8, 1, /* size */
 				       sizeof(buffer), buffer);
-	if (!piglit_check_gl_error(GL_INVALID_VALUE))
+	if (!piglit_check_gl_error(GL_INVALID_OPERATION))
 		pass = false;
 
 	/* Test get with undefined texture */
-- 
2.9.4



More information about the Piglit mailing list