[Piglit] [PATCH v6] pbo: Change the value expected from GetPixelMap.
Ian Romanick
idr at freedesktop.org
Wed Jun 28 21:18:31 UTC 2017
Excellent. I've added that information and pushed the patch.
On 06/28/2017 04:48 AM, sandra koroniewska wrote:
> + piglit
>
> On Tue, Jun 27, 2017 at 3:03 PM, sandra koroniewska
> <sandra.koroniewska at gmail.com <mailto:sandra.koroniewska at gmail.com>> wrote:
>
> Hi, I checked on the Intel and Nvidia Windows driver and the
> GL_MAX_PIXEL_MAP_TABLE was 65536 on both.
> I found something like
> this: http://feedback.wildfiregames.com/report/opengl/feature/GL_MAX_PIXEL_MAP_TABLE
> <http://feedback.wildfiregames.com/report/opengl/feature/GL_MAX_PIXEL_MAP_TABLE>
> It looks like the number can be different (mainlny 65536 or 256)
> depending on the graphics card.
>
> Regards,
> Sandra
>
> On Tue, Jun 27, 2017 at 12:42 AM, Ian Romanick <idr at freedesktop.org
> <mailto:idr at freedesktop.org>> wrote:
>
> On 06/22/2017 05:17 AM, Sandra Koroniewska wrote:
> > This fixes tests/spec/gl-2.1/pbo on Windows Intel driver.
>
> I'm assuming this fixes the test because GL_MAX_PIXEL_MAP_TABLE
> is not
> 256. What is that value? I'll add that information to the commit
> message when I push the patch for you.
>
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com
> <mailto:ian.d.romanick at intel.com>>
>
> > ---
> > tests/spec/gl-2.1/pbo.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/spec/gl-2.1/pbo.c b/tests/spec/gl-2.1/pbo.c
> > index bb4c0352c..5020eeb07 100644
> > --- a/tests/spec/gl-2.1/pbo.c
> > +++ b/tests/spec/gl-2.1/pbo.c
> > @@ -353,7 +353,7 @@ test_pixel_map(void)
> > }
> >
> > for (i = 0; i < max; i++) {
> > - if (pbo_mem[i] != (255 - i)) {
> > + if (pbo_mem[i] != max - i - 1) {
> > REPORT_FAILURE("get
> PixelMap failed");
> > return PIGLIT_FAIL;
> > }
> >
>
>
>
>
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
>
More information about the Piglit
mailing list