[Piglit] [PATCH 1/1] cl: Unmap mapped cl buffer in buffer-flags test

Francisco Jerez currojerez at riseup.net
Tue Mar 28 00:28:09 UTC 2017


Jan Vesely <jan.vesely at rutgers.edu> writes:

> On Thu, 2017-03-16 at 19:17 -0400, Jan Vesely wrote:
>> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
>> ---
>>  tests/cl/custom/buffer-flags.c | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/tests/cl/custom/buffer-flags.c b/tests/cl/custom/buffer-flags.c
>> index 115fb92..1429de0 100644
>> --- a/tests/cl/custom/buffer-flags.c
>> +++ b/tests/cl/custom/buffer-flags.c
>> @@ -173,6 +173,8 @@ buffer_test(piglit_cl_context *ctx,
>>  
>>  	/* cleanup */
>>  cleanup:
>> +	if (result != out_buffer)
>> +		clEnqueueUnmapMemObject(context->command_queues[0], out_buffer, result, 0, NULL, NULL);
>>  	clReleaseMemObject(in_buffer);
>>  	clReleaseMemObject(out_buffer);
>>  	clReleaseKernel(kernel);
>
> ping.
> this fixes test behaviour that was the motivation for clover pipe
> reference counting (14b543bd)
>
> are you interested in OCL piglit patches? should I just drop you from
> cc?
>

I'm not familiar with the code of this piglit test so I cannot give you
an informed review, but feel free to add my

Acked-by: Francisco Jerez <currojerez at riseup.net>

if that's useful to you...

> Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170327/991186c1/attachment.sig>


More information about the Piglit mailing list