[Piglit] [PATCH] beginend-coverage: change the incorect parameter for glMaterialf and glMateriali.

[Ilia Mirkin]

While those reference pages are nice and convenient, they are not the
spec, and are often inaccurate. They're good for figuring out what a
function generally does, not all the corner cases. Separately, check
the gl3 version of that page (e.g.http://docs.gl/gl3/glMaterial). And
even if NVIDIA behaves a certain way, that is still not the spec. The
specs are, for your reference, located at

https://khronos.org/registry/OpenGL/index_gl.php#apispecs

You can find PDFs for all the various released GL versions. They
specify in excruciating detail all the possibilities and error
conditions.

Cheers,

  -ilia

On Thu, May 4, 2017 at 1:44 PM, sandra koroniewska
<sandra.koroniewska at gmail.com> wrote:
> Hi,
> I found this information here:
> https://www.khronos.org/registry/OpenGL-Refpages/gl2.1/xhtml/glMaterial.xml
> ("Specifies the single-valued material parameter of the face or faces that
> is being updated. Must be GL_SHININESS.")
> Tomorrow I can check this test on Nvidia driver to see if it also fails.
>
> Regards,
> Sandra
>
>
> On Thu, May 4, 2017 at 7:07 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>
>> On Thu, May 4, 2017 at 12:44 PM, Sandra Koroniewska
>> <sandra.koroniewska at gmail.com> wrote:
>> > This fixes
>> > spec/gl-1.0/beginend-coverage on a Windows Intel driver.
>>
>> If you believe this to be a bug in the test, please use spec citations
>> explaining why the test is wrong, not "it doesn't seem to work on my
>> closed-source driver".
>>
>> I don't see anything in the GL spec to suggest that this test is
>> broken, but perhaps I'm missing it.
>>
>>   -ilia
>
>