[Piglit] [PATCH v2] genned-names: correct the parameter for glBindBufferRange

[Dylan Baker]

I might suggest that if the visual studio you're using is < 2017, that you
install the editorconfig plugin (VS 2017 has built in support for
editorconfig). Piglit has a .editorconfig file which will automatically set the
whitespace correctly based on file type.

https://github.com/editorconfig/editorconfig-visualstudio#readme

Quoting sandra koroniewska (2017-05-05 12:01:02)
> Hi,
> thanks for your help and finding this information. I corrected the offset to 4
> and changed these spaces to tab in VS. Is this patch all right now?
> 
> Thanks,
> Sandra
> 
> On Fri, May 5, 2017 at 8:55 PM, Sandra Koroniewska <
> sandra.koroniewska at gmail.com> wrote:
> 
>     This fixes
>     tests/spec/gl-3.1/genned-names on Windows Intel driver. According to OpenGL
>     4.5 Spec page 81, offset is restricted to be a multiple of 4 for transform
>     feedback bindings.
>     ---
>      tests/spec/gl-3.1/genned-names.c | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
> 
>     diff --git a/tests/spec/gl-3.1/genned-names.c b/tests/spec/gl-3.1/genned-
>     names.c
>     index bc75ae4d6..f484997b0 100644
>     --- a/tests/spec/gl-3.1/genned-names.c
>     +++ b/tests/spec/gl-3.1/genned-names.c
>     @@ -157,7 +157,7 @@ test_bindbuffer_tfb()
>             glBindBufferBase(GL_TRANSFORM_FEEDBACK_BUFFER, 0, 600);
>             pass = piglit_check_gl_error(GL_INVALID_OPERATION) && pass;
> 
>     -       glBindBufferRange(GL_TRANSFORM_FEEDBACK_BUFFER, 0, 601, 0, 1);
>     +       glBindBufferRange(GL_TRANSFORM_FEEDBACK_BUFFER, 0, 601, 0, 4);
>             pass = piglit_check_gl_error(GL_INVALID_OPERATION) && pass;
> 
>             return pass;
>     --
>     2.11.0.windows.1
> 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170505/1962483f/attachment.sig>