[Piglit] [PATCH v2] genned-names: correct the parameter for glBindBufferRange

[Ilia Mirkin]

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

This makes sense to me. TFB's are apparently required to be aligned to
4 bytes, even though in earlier documents there's various talk of
"basic machine units", which I can never remember what they are.
Either way, 4 makes sense to me.

On Fri, May 5, 2017 at 2:55 PM, Sandra Koroniewska
<sandra.koroniewska at gmail.com> wrote:
> This fixes
> tests/spec/gl-3.1/genned-names on Windows Intel driver. According to OpenGL 4.5 Spec page 81, offset is restricted to be a multiple of 4 for transform feedback bindings.

It's usual to mention the section number and section name, as well as
whether it's the core or compat profile spec that's being cited.

The committer can probably fix this up. Might be me tonight if I
remember, otherwise someone else can take care of it. Thanks!

> ---
>  tests/spec/gl-3.1/genned-names.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/spec/gl-3.1/genned-names.c b/tests/spec/gl-3.1/genned-names.c
> index bc75ae4d6..f484997b0 100644
> --- a/tests/spec/gl-3.1/genned-names.c
> +++ b/tests/spec/gl-3.1/genned-names.c
> @@ -157,7 +157,7 @@ test_bindbuffer_tfb()
>         glBindBufferBase(GL_TRANSFORM_FEEDBACK_BUFFER, 0, 600);
>         pass = piglit_check_gl_error(GL_INVALID_OPERATION) && pass;
>
> -       glBindBufferRange(GL_TRANSFORM_FEEDBACK_BUFFER, 0, 601, 0, 1);
> +       glBindBufferRange(GL_TRANSFORM_FEEDBACK_BUFFER, 0, 601, 0, 4);
>         pass = piglit_check_gl_error(GL_INVALID_OPERATION) && pass;
>
>         return pass;
> --
> 2.11.0.windows.1
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit