[Piglit] [PATCH v4] CMake: define GBM_BO_MAP only when symbol is found

[Daniel Díaz]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello!


On 05/16/2017 03:06 PM, Jan Vesely wrote:
> On Mon, 2017-05-15 at 20:27 -0500, Daniel Díaz wrote:
>> diff --git a/CMakeLists.txt b/CMakeLists.txt index 
>> a4ff99e..cc26fa8 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt
>> @@ -141,8 +141,9 @@ IF(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
>> if(GBM_FOUND) set(PIGLIT_HAS_GBM True) 
>> add_definitions(-DPIGLIT_HAS_GBM) -		if (GBM_VERSION 
>> VERSION_EQUAL "12.1" OR GBM_VERSION VERSION_GREATER "12.1") - 
>> set(PIGLIT_HAS_GBM_BO_MAP True)
> you still need to preserve the above line ^^, otherwise it breaks 
> the check on line 197.

But it is still defined, right? The CheckSymbolExists module defines
PIGLIT_HAS_GBM_BO_MAP which can be used in the condition down below,
in true ("1") or false ("") form.

This snippet (similar to line ~197) seems to work as expected:
  CHECK_FUNCTION_EXISTS(bogus_fx BOGUS_COND)
  if(False OR BOGUS_COND)
          message(FATAL_ERROR "True here")
  ELSE()
          message(FATAL_ERROR "False here")
  ENDIF()

Please let me know if I'm missing something.

Thanks and greetings

Daniel Díaz
daniel.diaz at linaro.org

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBCAAGBQJZG2JyAAoJECjqyWJ/sbDPdIMIAJJdqvIikw/ltwAUOPrk2gT9
xhOvt6pWUpyla9iOvyShUqziH15pArKU9Ghm+AP1LVhl7BeD1P6xDiB0JUGaqXV3
6+j7RtwjlBBzsJC6ILX5Gyk2s3KqaNyCICMTNScZAn6cWpsZsVZtNVmR4q6RwsHU
30kQyV6/wUE9WKuOmUbyCxXh4hJtsLa4F+ROXGpseKkHcMEhwlMcjaiZqORf0wm4
tBf+o0sF8Gohapjm1xkuqCrTEurm3l4F2VsxMMYpaofMH2FtTJjfBGXd83yrFYo5
2RKUwU0bD1JDIk1JSjaXWxarxYTwTHgT0qtvSlgUorK3piMu5UjzPw5YrFH7OTw=
=Ksw/
-----END PGP SIGNATURE-----