[Piglit] [PATCH 4/5] framework: Add command.setter method to Test

[Timothy Arceri]

On 18/05/17 19:17, Michel Dänzer wrote:
> On 12/05/17 01:47 PM, Timothy Arceri wrote:
>> From: Dylan Baker <dylan at pnwbakers.com>
>>
>> This allows the command to be overwritten or modified after
>> instantiation, which is useful for adding additional arguments in a
>> profile.
>>
>> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> 
> This change caused the gpu profile to no longer pass --quick to glean tests.
> 
> 

The overriding method is being ignored:

     @Test.command.getter
     def command(self):
         return super(GleanTest, self).command + self.GLOBAL_PARAMS

So --quick which is in self.GLOBAL_PARAMS never gets applied. I tried a 
few things to fix it without success but my python is to sucky to 
understand why this is happening, so I've sent a patch to test for the 
problem:

https://patchwork.freedesktop.org/patch/157234/