[Piglit] [PATCH v2] This fixes tests/spec/gl-2.1/pbo on Windows Intel driver. According to OpenGL Core spec 4.5, section 6.3.1 (Unmapping Buffers), page 75 "Unmapping a mapped buffer object invalidates the pointers to its data store" and to section 8.11.4 (Texture Image Queries) of the same spec on page 34 "If a pixel pack buffer is bound (as indicated by a non-zero value of PIXEL PACK BUFFER BINDING), data is an offset into the pixel pack buffer; otherwise,data is a pointer to client memory".

Sandra Koroniewska sandra.koroniewska at gmail.com
Thu May 25 14:11:25 UTC 2017


---
 tests/spec/gl-2.1/pbo.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/spec/gl-2.1/pbo.c b/tests/spec/gl-2.1/pbo.c
index bb4c0352c..700015c7e 100644
--- a/tests/spec/gl-2.1/pbo.c
+++ b/tests/spec/gl-2.1/pbo.c
@@ -305,7 +305,6 @@ test_pixel_map(void)
 				pbo_mem[i] = max - i - 1;
 
 			if (use_unpack) {
-				glUnmapBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB);
 				glPixelMapusv(GL_PIXEL_MAP_R_TO_R, max, NULL);
 				glPixelMapusv(GL_PIXEL_MAP_G_TO_G, max, NULL);
 				glPixelMapusv(GL_PIXEL_MAP_B_TO_B, max, NULL);
@@ -353,7 +352,7 @@ test_pixel_map(void)
 			}
 
 			for (i = 0; i < max; i++) {
-				if (pbo_mem[i] != (255 - i)) {
+				if (pbo_mem[i] != (max- i - 1)) {
 					REPORT_FAILURE("get PixelMap failed");
 					return PIGLIT_FAIL;
 				}
-- 
2.11.0.windows.1



More information about the Piglit mailing list