[Piglit] [PATCH] arb_get_program_binary: check correctly got_error

Lionel Landwerlin lionel.g.landwerlin at intel.com
Tue May 30 09:44:11 UTC 2017


Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 29/05/17 16:18, Juan A. Suarez Romero wrote:
> Seems it was checking if *not* error got, instead of the other way
> around.
>
> Suggested-by: Fabio Lagalla
> Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>
> ---
>   tests/spec/arb_get_program_binary/retrievable_hint.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/spec/arb_get_program_binary/retrievable_hint.c b/tests/spec/arb_get_program_binary/retrievable_hint.c
> index 8283c5b..9263a89 100644
> --- a/tests/spec/arb_get_program_binary/retrievable_hint.c
> +++ b/tests/spec/arb_get_program_binary/retrievable_hint.c
> @@ -79,7 +79,7 @@ piglit_init(int argc, char **argv)
>   	 */
>   	value = 0xDEADBEEF;
>   	glGetProgramiv(prog, GL_PROGRAM_BINARY_RETRIEVABLE_HINT, &value);
> -	got_error = piglit_check_gl_error(0);
> +	got_error = !piglit_check_gl_error(0);
>   
>   	if (!got_error) {
>   		if (value == 0xDEADBEEF) {




More information about the Piglit mailing list