[Piglit] [PATCH] glx_arb_create_context: Learn GLX_ARB_robustness_application_isolation

Brian Paul brianp at vmware.com
Wed Nov 8 04:35:09 UTC 2017


On 11/06/2017 03:21 PM, Adam Jackson wrote:
> This extension adds another valid context flag.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>   tests/spec/glx_arb_create_context/invalid-flag.c | 15 ++++++++++-----
>   1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/tests/spec/glx_arb_create_context/invalid-flag.c b/tests/spec/glx_arb_create_context/invalid-flag.c
> index 5df4c0146..254b9249d 100644
> --- a/tests/spec/glx_arb_create_context/invalid-flag.c
> +++ b/tests/spec/glx_arb_create_context/invalid-flag.c
> @@ -23,6 +23,10 @@
>   #include "piglit-glx-util.h"
>   #include "common.h"
>
> +#ifndef GLX_CONTEXT_RESET_ISOLATION_BIT_ARB
> +#define GLX_CONTEXT_RESET_ISOLATION_BIT_ARB 0x8
> +#endif
> +
>   static bool try_flag(uint32_t flag)
>   {
>   	const int attribs[] = {
> @@ -68,14 +72,15 @@ int main(int argc, char **argv)
>
>   	GLX_ARB_create_context_setup();
>
> -	/* If GLX_ARB_create_context_robustness is supported, the first flag
> -	 * that can be valid is GLX_CONTEXT_ROBUST_ACCESS_BIT_ARB.  Otherwise
> -	 * the first valid flag is GLX_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB.
> -	 */
> -	if (piglit_is_glx_extension_supported(dpy,
> +        /* Check for extensions that define higher-numbered flags */
> +        if (piglit_is_glx_extension_supported(dpy,
>   					      "GLX_ARB_create_context_robustness")) {
>   		first_valid_flag = GLX_CONTEXT_ROBUST_ACCESS_BIT_ARB;
>   	}
> +        if (piglit_is_glx_extension_supported(dpy,
> +                                              "GLX_ARB_robustness_application_isolation")) {
> +                first_valid_flag = GLX_CONTEXT_RESET_ISOLATION_BIT_ARB;
> +        }
>
>   	while (flag != first_valid_flag) {
>   		pass = try_flag(flag) && pass;
>

Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the Piglit mailing list