[Piglit] [PATCH 05/12] Port texture env test from Glean to Piglit

Fabian Bieler fabianbieler at fastmail.fm
Wed Nov 15 22:29:36 UTC 2017


On 2017-11-14 23:58, Brian Paul wrote:
> I'm getting a few compiler warnings from this test:
> 
> /home/brianp/piglit/tests/spec/gl-1.3/texture-env.c: In function
> ‘piglit_display’:
> /home/brianp/piglit/tests/spec/gl-1.3/texture-env.c:474:17: warning:
> passing argument 4 of ‘matrix_test’ from incompatible pointer type
>          COLORS, colors,
>                  ^
> /home/brianp/piglit/tests/spec/gl-1.3/texture-env.c:384:1: note:
> expected ‘const float (*)[4]’ but argument is of type ‘float (*)[4]’
>  matrix_test(GLenum env_mode, GLenum tex_format, int num_colors,
>  ^
> /home/brianp/piglit/tests/spec/gl-1.3/texture-env.c:483:8: warning:
> passing argument 4 of ‘matrix_test’ from incompatible pointer type
>         colors, colors[0])) {
>         ^
> /home/brianp/piglit/tests/spec/gl-1.3/texture-env.c:384:1: note:
> expected ‘const float (*)[4]’ but argument is of type ‘float (*)[4]’
>  matrix_test(GLenum env_mode, GLenum tex_format, int num_colors,
>  ^
> 
> Can you try to fix those?

This revised patch set should silence those warnings.

Sorry for the noisy patch the compilers I previously used didn't warn
about this conversion.

Fabian


More information about the Piglit mailing list