[Piglit] [PATCH] tests/egl/egl-context-priority.c: Use piglit_egl_get_default_display

Tapani Pälli tapani.palli at intel.com
Tue Nov 28 07:45:48 UTC 2017


I've changed commit msg to reuse the text from 45095dc08b and pushed the 
patch in, thanks!

On 11/27/2017 03:44 PM, Emil Velikov wrote:
> On 27 November 2017 at 07:27, Tapani Pälli <tapani.palli at intel.com> wrote:
>> Right, this works because Mali 450 driver does not support
>> EGL_MESA_platform_surfaceless, LGTM
>>
> Even if the driver did support the extension a static entry-point to
> link against is not guaranteed to be available.
> The EGL spec says that portable applications should use
> dlsym/eglGetProcAddress... which the helper does ;-)
> 
> I've looked at updating Mesa to hide these symbols but it's a bit tricky.
> 
>> Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
>>
>> On 11/24/2017 06:31 PM, Aníbal Limón wrote:
>>>
>>> From: Aníbal Limón <anibal.limon at linaro.org>
>>>
>>> Some EGL implementations do not actually ship all Khronos-extensions.
>>> As it turns out, the Mali 450 driver does not include
>>> eglGetPlatformDisplay
>>> symbol so there is not grauntee to exists use
>>> piglit_egl_get_default_display
>>
>>
>> This needs to be rewritten with proper English, not sure how. Maybe simply:
>>
>> "Mali 450 driver does not support eglGetPlatformDisplay, use
>> piglit_egl_get_default_display wrapper instead."
>>
>>
> Looks good, one could also reuse the text from 45095dc08b.
> In either case, patch is
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> -Emil
> 


More information about the Piglit mailing list