[Piglit] [PATCH 0/23] Port glsl1 Glean test to Piglit

[Brian Paul]

On 11/23/2017 01:44 PM, Fabian Bieler wrote:
> This series replaces the "glsl1" Glean test with some Piglit tests.
>
> Most tests were replaced by shader_runner tests.
>
> The tests for built-in-uniform state were extended.
>
> Some of the preprocessor tests were modified to make them stricter.
>
> To port some texture tests shader_runner had to be extended with
> "texture rgbw 1D" and "texture rgbw 3D" commands.
> These (and the underlying piglit-util-functions) are very basic and
> don't allow for variable texture size or pixel format. If desired, I can
> remedy that.
>
> Some tests ("Global vars and initializers", "Global vars and
> initializers (2)", "Swizzle", "Writemask") are pretty trivial. I doubt
> they would break without some existing, more complex Piglit test
> failing, too. However, I opted to port them regardless since I couldn't
> find an existing simple Piglit test for the feature in question.
>
> Attached is a list of all Glean GLSL subtests with the location of the
> new or existing Piglit test that replaces it.
>
> Patch 23 fixes an unrelated test.

I did a quick read-through and the series looks OK to me.  I presume 
there's no compiler warnings and all the tests pass/fail as the glean 
tests did.

If there's no other comments in a few days, I can push the series.

Reviewed-by: Brian Paul <brianp at vmware.com>