[Piglit] [PATCH] arb_shader_atomic_counter_ops: declare counters to fix undefined behaviour.

Dave Airlie airlied at gmail.com
Wed Oct 11 00:18:06 UTC 2017


From: Dave Airlie <airlied at redhat.com>

It's undefined (including crashing) behaviour to use atomic counters
without having bound enough storage for them. This fixes this test
to bind the storage for the counters it uses.

Signed-off-by: Dave Airlie <airlied at redhat.com>
---
 .../arb_shader_atomic_counter_ops/execution/all_touch_test.shader_test   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/spec/arb_shader_atomic_counter_ops/execution/all_touch_test.shader_test b/tests/spec/arb_shader_atomic_counter_ops/execution/all_touch_test.shader_test
index 7fb3cbf..913fa6b 100644
--- a/tests/spec/arb_shader_atomic_counter_ops/execution/all_touch_test.shader_test
+++ b/tests/spec/arb_shader_atomic_counter_ops/execution/all_touch_test.shader_test
@@ -68,5 +68,6 @@ void main()
 }
 
 [test]
+atomic counters 8
 draw rect -1 -1 2 2
 probe all rgba 0.0 1.0 0.0 1.0
-- 
2.9.5



More information about the Piglit mailing list