[Piglit] [PATCH 2/7] framework: fix a comment

Nicolai Hähnle nhaehnle at gmail.com
Wed Oct 11 10:12:50 UTC 2017


From: Nicolai Hähnle <nicolai.haehnle at amd.com>

See ReducedProcessMixin._run_command:

    if not self._is_cherry():
        ... rerun path ...
---
 framework/test/base.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/test/base.py b/framework/test/base.py
index e74ea3d38..0b7ebab2e 100644
--- a/framework/test/base.py
+++ b/framework/test/base.py
@@ -552,21 +552,21 @@ class ReducedProcessMixin(object):
             # Restore and keep the original returncode (so that it remains a
             # non-pass, since only one test might fail and the resumed part
             # might return 0)
             self.result.returncode = returncode
             self.result.out = '\n\n====RESUME====\n\n'.join(out)
             self.result.err = '\n\n====RESUME====\n\n'.join(err)
 
     def _is_cherry(self):
         """Method used to determine if rerunning is required.
 
-        If this returns True then the rerun path will be entered, otherwise
+        If this returns False then the rerun path will be entered, otherwise
         _run_command is effectively a bare call to super().
 
         Classes using this mixin may need to overwrite this if the binary
         they're calling can stop prematurely but return 0.
         """
         return self.result.returncode == 0
 
     def _populate_subtests(self):
         """Default implementation of subtest prepopulation.
 
-- 
2.11.0



More information about the Piglit mailing list